Skip to content

Add the ability to hide completed tasks#58

Closed
HelpfulSoft1207 wants to merge 1 commit into
mainfrom
hide-completed-tasks
Closed

Add the ability to hide completed tasks#58
HelpfulSoft1207 wants to merge 1 commit into
mainfrom
hide-completed-tasks

Conversation

@HelpfulSoft1207

@HelpfulSoft1207 HelpfulSoft1207 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Whats New

@HelpfulSoft1207 HelpfulSoft1207 self-assigned this Jun 22, 2026
@HelpfulSoft1207 HelpfulSoft1207 added the enhancement New feature or request label Jun 22, 2026
@HelpfulSoft1207

Copy link
Copy Markdown
Collaborator Author

@AnSq when you have a moment can you critique and also test this out to see if I missed anything please?

@AnSq

AnSq commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Oh, I also just started working on this feature. And to be honest, this looks way more complicated than the approach I took. I think the existing task hiding feature with hidden-task is a red herring, and this can be done much easier without reference to it at all. I also think it's possible to do most of this with just CSS and very little javascript.

It also looks like your version of it (intentionally?) doesn't apply to subtasks. Seems like an odd design choice, and not one that I would have made.

The 5 second delay is exactly what I was planning though.

I can finish mine up and create an alternate PR so you can better see what I'm talking about.

@HelpfulSoft1207

Copy link
Copy Markdown
Collaborator Author

To be completely honest, I forgot about subtasks when I was doing it and testing it, ha. So that is an oversight from my end.

Yes, please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants